[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Some technical suggestions

OK, some early comments first, from just perusing the code.


On the Redhat 6.0 box I am using it is 
When the next updates come they will probably use FHS rather than FSSTND
which in this case means the /usr/doc/ path will change to /usr/share/doc
(assuming no last minute changes).

# Checking for a tmp dir
if [ ! -e $WORKING_DIR/tmp/. ]
mkdir $WORKING_DIR/tmp

where WORKING_DIR="/usr/local/bin/ldp"
is rather dangerous, as the entire /usr tree should be workable
even if mounted read-only and across NFS. Since you use a
shell script you could use the old trick about TMP=/tmp/$$
where $$ expands into current process number.

For pulling files across you rely on wget, this should probably
be stated, or even checked for. Also it seems more user friendly
to check for write permission before attempting updates.

Things are a little busy here now so more feedback will have to
wait for a while. So far it looks like we are getting there.

   Stein Gjoen

To UNSUBSCRIBE, email to ldp-discuss-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org